MAINT: improve error message when meson isn't found #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
the
maintenance
rgommers
force-pushed
the
improve-custom-meson-error
branch
from
b292895 to
e0f4c97
Compare
dnicolodi
requested changes
May 17, 2024
Member
dnicolodi
left a comment
dnicolodi
left a comment
There was a problem hiding this comment.
Thanks @rgommers. It looks good, except for some nitpicking about the spelling of the error messages. Curiously I have similar patch queued locally. In that I also check the return code of meson --version and raise an error with what was printed on the standard error if the return code is not zero.
There are several ways that meson may go missing: - a non-isolated build and meson isn't installed - meson executable is specified in pyproject.toml and git submodule is containing it is not initialized (reported as resulting in a confusing error in numpy#26397) - MESON environmnent variable is used by the user and is misspelled The git submodule case was ending with: ``` meson-python: error: Could not find meson version 0.63.3 or newer, found . ``` and after this ends with: ``` meson-python: error: Could not find the specified meson: "vendored-meson/meson/meson.py" ``` If the executable is missing, the build ended with a very long traceback. Changing `FileNotFoundError` to `ConfigError` elides the traceback and clearly reports that the executable wasn't found. Easy to verify with any package with: ``` $ MESON=nonsense python -m build -wnx * Building wheel... meson-python: error: meson executable "nonsense" not found ERROR Backend subproccess exited when trying to invoke build_wheel ```
rgommers
force-pushed
the
improve-custom-meson-error
branch
from
e0f4c97 to
1dd18b6
Compare
Contributor
Author
|
Thanks @dnicolodi. Adopted your suggestions for error messages.
If you have that already, do you want to put that on top of this PR (either push a commit or do in a follow-up PR)? |
Member
|
Sure, I will do that later today. |
dnicolodi
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to gh-495.
There are several ways that meson may go missing:
MESONenvironmnent variable is used by the user and is misspelledThe git submodule case was ending with:
and after this ends with:
If the executable is missing, the build ended with a very long traceback. Changing
FileNotFoundErrortoConfigErrorelides the traceback and clearly reports that the executable wasn't found. Easy to verify with any package with:Closes numpy/numpy#26397